Use format SQL settings when creating new notebook #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neelasha23
force-pushed
the
issue114
branch
2 times, most recently
from
afcd0b2
to
4bd8bd7
Compare
neelasha23
commented
Jun 14, 2024
| @@ -6,7 +6,7 @@ test('test format SQL', async ({ page }) => { | |||
| await page.notebook.openByPath("sample.ipynb"); | |||
| await page.notebook.activate("sample.ipynb"); | |||
| await page.notebook.addCell("code", "%%sql\nselect * from table") | |||
| await page.getByTestId('format-btn').locator('button').click(); | |||
| await page.getByTestId('format-btn').locator('button').click({ force: true }); | |||
There was a problem hiding this comment.
I faced this issue in the CI on the main branch as well as the current branch:
waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <span class="jp-ToolbarButtonComponent-label">Format SQL</span> intercepts pointer events
- retrying click action, attempt #93
Fixed using this solution
edublancas
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number
Closes #114
Checklist before requesting a review
pkgmt format