Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break slate linkintegrity if block is not a slate block #1849

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Dec 3, 2024

These are some compatibility fixes when blocks are not proper slate blocks.

We registered some linkintegrity adapters that extends slate one, but in some cases (we have some old installations that does not have slate yet) some methods breaks.

This pr tries to graceful handle them.


📚 Documentation preview 📚: https://plonerestapi--1849.org.readthedocs.build/

@cekk cekk requested a review from davisagli December 3, 2024 12:45
@mister-roboto
Copy link

@cekk thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@cekk
Copy link
Member Author

cekk commented Dec 3, 2024

@jenkins-plone-org please run jobs

news/1849.bugfix Outdated Show resolved Hide resolved
@davisagli davisagli merged commit 09c8b01 into main Dec 17, 2024
21 of 25 checks passed
@davisagli davisagli deleted the cekk_blocks_linkintegrity_compat branch December 17, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants