Do not change request during serialization of relation fields #1845
Conversation
|
@cekk thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Thanks for the fix.
It would be nice if the __call__ method of the ISerializeToJsonSummary adapter took an optional parameter to override the metadata_fields, so that it would not need to be passed via the request. But, this is not easily backwards compatible. So I'll accept your fix.
| ) | ||
| ] | ||
| self.serialize("test_relationchoice_field", doc2) | ||
| self.assertEqual(self.request.form["metadata_fields"], ["foo", "bar"]) |
There was a problem hiding this comment.
It'd be slightly preferable to use real metadata names and check that they are present in the serialized object (in other words, test the result, not the implementation)
Serializer should not change current request.
I cloned it to allow adding UID to the data and not touching original request.
📚 Documentation preview 📚: https://plonerestapi--1845.org.readthedocs.build/