-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Plone Sphinx Theme for documentation, include changes to http-examples to build docs preview #1815
Conversation
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
…mple requires its pkg_resources
@jenkins-plone-org please run jobs |
There are two issues with the theme, which I can resolve in a future pull request, as this is an improvement.
|
This really looks weird, no contrast. It really needs to be fixed. |
… obliterate the virtual environment. Most of the time, I just want to purge the built docs, not the virtual environment.
This should be fixed in PST 0.0.15. Preview: https://plonerestapi--1815.org.readthedocs.build/en/1815/endpoints/aliases.html#adding-new-url-aliases-for-a-page |
The ScrollSpy bug is weird. Something in this repo interferes with it, as it is fine in the PST docs. If anyone can spy the issue, I'd appreciate the assist. |
@jenkins-plone-org please run jobs |
I'm not sure why the one Jenkins run fails, as this PR has nothing to do with its failing tests. |
http-examples
directory is now included for pull request previews.Closes #1097
📚 Documentation preview 📚: https://plonerestapi--1815.org.readthedocs.build/