Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include next/previous only if enabled #1799

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Aug 12, 2024

Fixes #1797

@mister-roboto
Copy link

@JeffersonBledsoe thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli davisagli changed the title WIP: Next previous indication Include next/previous only if enabled Aug 26, 2024
@davisagli davisagli marked this pull request as ready for review August 26, 2024 18:43
@davisagli davisagli merged commit 37d02e7 into main Aug 26, 2024
24 checks passed
@davisagli davisagli deleted the next-previous-indication branch August 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to determine whether next/ previous should be used from a content response
3 participants