-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Teaser blocks dynamic #1788
Conversation
@pbauer thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
@jenkins-plone-org please run jobs |
@pbauer could you take care of Jens suggestion? |
Co-authored-by: Jens W. Klein <[email protected]>
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs tests. I have some in a project that I might be able to adapt.
@jenkins-plone-org please run jobs |
@pbauer @davisagli good work! Shall we make a release with this new feature? I am wondering if a major release would make it easier for us to keep things in sync with the Volto 18 release which this feature will be shipped with, right @sneridagh? |
Yes, the plan is to have it paired with 18 and 6.1. I'm ok with a major, up to you though. We need a release asap, so we can have the Volto side merged. I plan to work on it during the sprint. |
I gave this some thought and I will release a feature release. For "internal" packages it makes lots of sense to stick with strict semantic versioning. |
@pbauer @davisagli @sneridagh FYI: I released this with p.restapi 9.7.0: https://pypi.org/project/plone.restapi/9.7.0/ |
PLIP: plone/volto#6023
Depends on plone/volto#6024 but should not break anything without it.