Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Teaser blocks dynamic #1788

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Make Teaser blocks dynamic #1788

merged 11 commits into from
Jun 12, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented May 16, 2024

PLIP: plone/volto#6023
Depends on plone/volto#6024 but should not break anything without it.

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link

netlify bot commented May 16, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 6f0dcbf
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/666a1210e955040008523ceb

@pbauer pbauer requested review from davisagli and pnicolli May 17, 2024 09:26
@pbauer pbauer mentioned this pull request May 17, 2024
3 tasks
@sneridagh
Copy link
Member

@jenkins-plone-org please run jobs

@sneridagh
Copy link
Member

@pbauer could you take care of Jens suggestion?
@davisagli could you please take a look?

@pbauer
Copy link
Member Author

pbauer commented Jun 10, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests. I have some in a project that I might be able to adapt.

news/1788.feature Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit bbff5b8 into main Jun 12, 2024
28 checks passed
@davisagli davisagli deleted the teaser-dynamic branch June 12, 2024 22:59
@tisto
Copy link
Member

tisto commented Jun 14, 2024

@pbauer @davisagli good work! Shall we make a release with this new feature?

I am wondering if a major release would make it easier for us to keep things in sync with the Volto 18 release which this feature will be shipped with, right @sneridagh?

@sneridagh
Copy link
Member

Yes, the plan is to have it paired with 18 and 6.1. I'm ok with a major, up to you though.

We need a release asap, so we can have the Volto side merged. I plan to work on it during the sprint.

@tisto
Copy link
Member

tisto commented Jun 15, 2024

I gave this some thought and I will release a feature release. For "internal" packages it makes lots of sense to stick with strict semantic versioning.

@tisto
Copy link
Member

tisto commented Jun 15, 2024

@pbauer @davisagli @sneridagh FYI: I released this with p.restapi 9.7.0: https://pypi.org/project/plone.restapi/9.7.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants