Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing test req #1784

Merged
merged 2 commits into from
May 16, 2024
Merged

Fixes missing test req #1784

merged 2 commits into from
May 16, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented May 15, 2024

fixes #1782 #1783

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link

netlify bot commented May 15, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit c24b60d
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/66452ddac0bcdc0008239131

@jensens jensens requested a review from ericof May 15, 2024 21:49
@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@jensens jensens merged commit 5b33ccd into main May 16, 2024
25 checks passed
@jensens jensens deleted the fixes-missing-test-req branch May 16, 2024 14:00
mauritsvanrees added a commit to plone/plone.volto that referenced this pull request Jun 18, 2024
`plone.app.iterate` is temporary until `plone.restapi[test]` contains it in all versions we care about.
See plone/plone.restapi#1784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require plone.app.iterate on test extras
4 participants