Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new @login endpoint to return available external login options #1757
base: main
Are you sure you want to change the base?
add new @login endpoint to return available external login options #1757
Changes from 18 commits
cf79461
3ff293b
783a079
cc1347c
6cf2636
98c0cf5
68ce3be
46f891e
879752e
53002d4
37c47e7
06be87c
8168d4a
961def7
3cd4daa
0eccce4
499d74a
c97c97b
4cc4288
fd67f94
1a0c196
861673f
7a9e378
83c802e
f52a73d
92ae900
49a018f
b5c5899
730e8d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be defined in plone.base instead of plone.restapi, so that an addon doesn't need to depend on plone.restapi just to register this adapter and provide information about what providers it supports?
On the other hand, that would make it harder to backport support for this feature to older versions of Plone.
I don't feel strongly about it but in general, plone.restapi's purpose is to provide API access to features that exist at a lower level and might also be accessed via other interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole idea of the endpoint is to avoid duplicated
@login
endpoints such the ones we have in pas.plugins.authomatic and pas.plugins.oidc to support volto-authomaticI agree that perhaps this should go in plone.base somewhere and integrate it with Plone's standard login page.
Perhaps we can open an issue in Plone and work on that later on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my rename of the docs file, should this be changed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is for the test-generated request and response file. I would leave this as it is, because we already have
login.req
file in the http-examples folder