-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'not' queries with @search endpoint. #1752
base: main
Are you sure you want to change the base?
Conversation
@maethu thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
35334f6
to
95834e9
Compare
95834e9
to
7c26758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maethu This is already supported by the @querystring-search
endpoint using the isNot
and none
operations (see plone/plone.app.querystring#110). Is there a reason it's needed for the @search
endpoint as well?
Thanks very much, @davisagli, I'm aware of that. On my project, I use the No hard feelings if it does not make sense in plone.restapi. I can keep my patch in my project. I just thought maybe it would make sense to give this upstream. |
@jenkins-plone-org please run jobs |
@davisagli let's discuss this in the next days. @maethu it would be awesome to have our docs updated to reflect this change. Without proper docs, we can not merge any PR. |
This PR adds support to exclude certain items from the result set using
not
for DateIndex, FieldIndex and KeywordIndex.Example request:
Returns all items not having the subject "important".
Only works with Plone 6