Test showing the difference #1716
Conversation
✅ Deploy Preview for plone-restapi canceled.
|
|
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
wesleybl
force-pushed
the
test_different_image_scales_in_serialization_and_catalog
branch
from
61951e5 to
6e081ff
Compare
|
@sneridagh @davisagli this issue was fixed in: The test is passing now. |
wesleybl
deleted the
test_different_image_scales_in_serialization_and_catalog
branch
|
@wesleybl Then shouldn't we merge the test, to make sure there isn't a future regression, instead of closing the PR? |
wesleybl
restored the
test_different_image_scales_in_serialization_and_catalog
branch
|
@sneridagh thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@davisagli Okay. I made some fixes. |
|
@jenkins-plone-org please run jobs |
wesleybl
force-pushed
the
test_different_image_scales_in_serialization_and_catalog
branch
from
f7fb7bb to
13f1d47
Compare
|
@jenkins-plone-org please run jobs |
|
@sneridagh @davisagli can you merge this PR please? I think Plone 6.1 is no longer tested with Python 3.8 in Jenkins. |
|
@wesleybl I updated the repository's branch protection rules so that it requires the Plone 6.1 + Python 3.10 build instead of Python 3.8. |
davisagli
deleted the
test_different_image_scales_in_serialization_and_catalog
branch
The test fails right now.