Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.7 support #1710

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Drop Python 3.7 support #1710

merged 5 commits into from
Sep 22, 2023

Conversation

tisto
Copy link
Member

@tisto tisto commented Sep 22, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 9059ace
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/650dab1c6a650000089b4e08

@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

tisto
tisto commented Sep 22, 2023
View reviewed changes
README.rst Outdated
plone.restapi 8 requires Python 3 and works with Plone 5.2 and Plone 6.x.

plone.restapi 8 does not officially support Python 3.6.
plone.restapi 8 and 9 require Python 3 and work with Plone 5.2 and Plone 6.x.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauritsvanrees @davisagli FYI: I updated the README to reflect our "more strict" policy regarding old Python versions.

@tisto
Copy link
Member Author

tisto commented Sep 22, 2023

@jenkins-plone-org please run jobs

tisto
tisto commented Sep 22, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@tisto
Copy link
Member Author

tisto commented Sep 22, 2023

I triggered a Jenkins job manually: https://jenkins.plone.org/job/pull-request-6.0-3.11/851/

stevepiercy
stevepiercy requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good. Minor MyST syntax clarification. Thank you!

news/1570.bugfix Outdated Show resolved Hide resolved
@tisto @stevepiercy
Update news/1570.bugfix
055312e 
Co-authored-by: Steve Piercy <[email protected]>
@tisto tisto enabled auto-merge (squash) September 22, 2023 15:13
@tisto tisto disabled auto-merge September 22, 2023 16:37
@tisto tisto merged commit 3930ca2 into main Sep 22, 2023
18 checks passed
@tisto tisto deleted the drop-py37 branch September 22, 2023 16:37
@davisagli davisagli mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisto @mister-roboto @stevepiercy @mauritsvanrees