Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport #1465: @site and @navroot endpoints #1702

Merged
merged 19 commits into from
Oct 28, 2023

Conversation

erral
Copy link
Member

@erral erral commented Sep 15, 2023

Backport of #1465 to 7.x.x to have it for plone/volto#5185

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Sep 15, 2023

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Sep 15, 2023

See: plone/volto#5185

@erral
Copy link
Member Author

erral commented Sep 21, 2023

eh... how are we testing the 7.x.x branch in python 2.7? It is not available on github actions... @plone/restapi-team

@davisagli
Copy link
Member

@erral There is still a Jenkins job which tests on Python 2.7

@tisto
Copy link
Member

tisto commented Sep 21, 2023

@erral I remember that you can use an old ubuntu image on GHA that still ships with Python 2.7. Not sure if that still is the case though. It gets harder and harder to support Python 2.7 these days :(

@erral
Copy link
Member Author

erral commented Sep 21, 2023

@erral There is still a Jenkins job which tests on Python 2.7

where all robot tests fail 😒

@davisagli
Copy link
Member

@erral There are some syntax errors in Python 2

@davisagli
Copy link
Member

@erral I think it would be fine to disable the new endpoints entirely for Plone 4.3 (i.e. with conditional zcml, plus skipping the tests on 4.3)

@erral
Copy link
Member Author

erral commented Oct 18, 2023

@davisagli the whole point of this PR was to bring @site and @navroot to Plone 4.3 as per plone/volto#5185 (comment)

I will try to fix the issues.

@davisagli
Copy link
Member

@erral Oops, right, I forgot. Carry on, then.

@erral
Copy link
Member Author

erral commented Oct 18, 2023

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Oct 19, 2023

Green!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral Thanks!

@davisagli davisagli merged commit 79cce5e into 7.x.x Oct 28, 2023
8 checks passed
@davisagli davisagli deleted the erral-7.x.x-site-and-navroot branch October 28, 2023 21:24
@mauritsvanrees
Copy link
Member

I have released this in plone.restapi 7.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants