- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose private metadata via relationfield serializer. #1635
Open
maethu
wants to merge
2
commits into
main
Choose a base branch
from
mle-fix-relationfield-permission-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−3
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Do not expose private metadata via relationfield serializer.
commit b5124fa366641876dd44fa526f02caa45771ca5b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Do not expose private metadata via relationfield serializer. | ||
[maethu] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,3 +1,4 @@ | ||||||||||||||||
from plone import api | ||||||||||||||||
from plone.dexterity.interfaces import IDexterityContent | ||||||||||||||||
from plone.restapi.interfaces import IFieldSerializer | ||||||||||||||||
from plone.restapi.interfaces import IJsonCompatible | ||||||||||||||||
|
@@ -17,7 +18,8 @@ | |||||||||||||||
@adapter(IRelationValue) | ||||||||||||||||
@implementer(IJsonCompatible) | ||||||||||||||||
def relationvalue_converter(value): | ||||||||||||||||
if value.to_object: | ||||||||||||||||
mtool = api.portal.get_tool("portal_membership") | ||||||||||||||||
if value.to_object and mtool.checkPermission("View", value.to_object): | ||||||||||||||||
request = getRequest() | ||||||||||||||||
request.form["metadata_fields"] = ["UID"] | ||||||||||||||||
summary = getMultiAdapter((value.to_object, request), ISerializeToJsonSummary)() | ||||||||||||||||
|
@@ -33,4 +35,9 @@ class RelationChoiceFieldSerializer(DefaultFieldSerializer): | |||||||||||||||
@adapter(IRelationList, IDexterityContent, Interface) | ||||||||||||||||
@implementer(IFieldSerializer) | ||||||||||||||||
class RelationListFieldSerializer(DefaultFieldSerializer): | ||||||||||||||||
pass | ||||||||||||||||
def __call__(self): | ||||||||||||||||
value = self.get_value() | ||||||||||||||||
if value: | ||||||||||||||||
return [item for item in json_compatible(value) if item] | ||||||||||||||||
else: | ||||||||||||||||
return super().__call__() | ||||||||||||||||
Comment on lines
+44
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the sake of readability: No |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is too much overhead and probably slow. Use the Zope basics, those are perfectly fine here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, if you anyway use
plone.api
, there isapi.user.check_permission
too as an alternative.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not wrong, plone.api may only be used in plone.restapi tests right? @plone/restapi-team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what the rules are, but if there are those rules, they must be documented somewhere.