Skip to content

Commit

Permalink
Handle aliases in path2uid
Browse files Browse the repository at this point in the history
  • Loading branch information
cekk committed Nov 26, 2024
1 parent a5b547e commit c3306d2
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/plone/restapi/deserializer/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
from plone.uuid.interfaces import IUUID
from plone.uuid.interfaces import IUUIDAware
from zope.component import getMultiAdapter
from plone.app.redirector.interfaces import IRedirectionStorage
from zope.component import getUtility

import re

PATH_RE = re.compile(r"^(.*?)((?=/@@|#).*)?$")
Expand Down Expand Up @@ -35,6 +38,14 @@ def path2uid(context, link):
suffix = match.group(2) or ""

obj = portal.unrestrictedTraverse(path, None)
if obj is None:
# last try: maybe the object or some parent has been renamed.
# if yes, there should be a reference into redirection storage
storage = getUtility(IRedirectionStorage)
alias_path = storage.get(path)
if alias_path:
path = alias_path
obj = portal.unrestrictedTraverse(path, None)
if obj is None or obj == portal:
return link
segments = path.split("/")
Expand Down
14 changes: 14 additions & 0 deletions src/plone/restapi/tests/test_blocks_deserializer.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from plone import api
from plone.dexterity.interfaces import IDexterityFTI
from plone.dexterity.interfaces import IDexterityItem
from plone.restapi.behaviors import IBlocks
Expand Down Expand Up @@ -724,3 +725,16 @@ def test_deserialize_url_with_image_scales(self):
res = self.deserialize(blocks=blocks)
self.assertTrue(res.blocks["123"]["url"].startswith("../resolveuid/"))
self.assertNotIn("image_scales", res.blocks["123"])

def test_deserializer_resolve_path_also_if_it_is_an_alias(self):

self.portal.invokeFactory(
"Document",
id="doc",
)
api.content.move(source=self.portal.doc, id="renamed-doc")
blocks = {"abc": {"href": "%s/doc" % self.portal.absolute_url()}}

res = self.deserialize(blocks=blocks)
link = res.blocks["abc"]["href"]
self.assertTrue(link.startswith("../resolveuid/"))

0 comments on commit c3306d2

Please sign in to comment.