Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot test Add a Comment to a Document and bulk delete it #238

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Apr 15, 2024

The screenshot shows that the "Select all" checkbox is checked, but the other checkboxes are not. It may be that the test clicked on "Select all" before the event that selects all was attached to the checkbox. Then we wait for the event to be attached before clicking.

This fixes: https://jenkins.plone.org/job/pull-request-6.1-3.12/281/robot/report/robot_log.html#s1-s34-t1

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

@jenkins-plone-org please run jobs

The screenshot shows that the "Select all" checkbox is checked, but the
other checkboxes are not. It may be that the test clicked on "Select
all" before the event that selects all was attached to the checkbox.
Then we wait for the event to be attached before clicking.
@wesleybl wesleybl merged commit 7b7947e into master Apr 15, 2024
12 of 13 checks passed
@wesleybl wesleybl deleted the fix_robot branch April 15, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants