Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright based robot test #214

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Playwright based robot test #214

merged 3 commits into from
Oct 18, 2024

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jun 28, 2023

This is part of plone/Products.CMFPlone#3813

They are expected to fail for now, we need to figure out CI specially.

See plone/Products.CMFPlone#3813 for how to run them locally as CI is getting ready for it.

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada
Copy link
Member Author

gforcada commented Oct 6, 2023

@jenkins-plone-org please run jobs

@gforcada gforcada marked this pull request as ready for review October 6, 2023 12:10
@1letter 1letter force-pushed the playwright-based-robot-test branch from af2830e to af97ba7 Compare October 17, 2024 07:38
@1letter 1letter force-pushed the playwright-based-robot-test branch from af97ba7 to dc7dc60 Compare October 17, 2024 07:40
@1letter
Copy link
Contributor

1letter commented Oct 17, 2024

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

The failing test is unrelated to this PR.

@petschki petschki merged commit 60f3167 into main Oct 18, 2024
11 of 12 checks passed
@petschki petschki deleted the playwright-based-robot-test branch October 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants