Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[fc] Repository: Products.validation
Branch: refs/heads/master Date: 2024-08-12T11:35:55+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@5b5d67e Configuring with plone/meta Files changed: A .editorconfig A .flake8 A .github/workflows/meta.yml A .meta.toml A .pre-commit-config.yaml A dependabot.yml A news/+meta.internal A tox.ini M .gitignore M pyproject.toml Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:37:34+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@72c1d5a Remove no longer needed setup.cfg. Files changed: D setup.cfg Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:42:31+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@38ebcbd pyupgrade Files changed: M Products/validation/chain.py M Products/validation/i18n.py M Products/validation/tests/test_validation.py M Products/validation/validators/BaseValidators.py M Products/validation/validators/EmptyValidator.py M Products/validation/validators/ExpressionValidator.py M Products/validation/validators/IdValidator.py M Products/validation/validators/RangeValidator.py M Products/validation/validators/RegexValidator.py M Products/validation/validators/SupplValidators.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:43:34+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@2a575ed Remove six. Files changed: M Products/validation/i18n.py M Products/validation/service.py M Products/validation/tests/test_validation.py M Products/validation/validators/RegexValidator.py M setup.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:44:04+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@e275528 isort Files changed: M Products/validation/__init__.py M Products/validation/config.py M Products/validation/i18n.py M Products/validation/interfaces/IValidationService.py M Products/validation/interfaces/IValidator.py M Products/validation/interfaces/__init__.py M Products/validation/service.py M Products/validation/tests/test_validation.py M Products/validation/validators/BaseValidators.py M Products/validation/validators/EmptyValidator.py M Products/validation/validators/ExpressionValidator.py M Products/validation/validators/IdValidator.py M Products/validation/validators/RangeValidator.py M Products/validation/validators/RegexValidator.py M Products/validation/validators/SupplValidators.py M Products/validation/validators/__init__.py M Products/validation/validators/validator.py M setup.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:45:02+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@d8b5726 black Files changed: M Products/__init__.py M Products/validation/ZService.py M Products/validation/chain.py M Products/validation/exceptions.py M Products/validation/i18n.py M Products/validation/interfaces/IValidationService.py M Products/validation/interfaces/IValidator.py M Products/validation/service.py M Products/validation/tests/__init__.py M Products/validation/tests/test_validation.py M Products/validation/validators/BaseValidators.py M Products/validation/validators/EmptyValidator.py M Products/validation/validators/ExpressionValidator.py M Products/validation/validators/IdValidator.py M Products/validation/validators/RangeValidator.py M Products/validation/validators/RegexValidator.py M Products/validation/validators/SupplValidators.py M setup.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T11:45:40+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@edb7ace Another pyupgrade. Files changed: M Products/validation/chain.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:24+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@7c8b28a doesnt -> does not Files changed: M Products/validation/validators/ExpressionValidator.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:24+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@610cba6 ispell Files changed: M CHANGES.rst M docs/ChangeLog Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@a452d4c flake8: ignore unused imports in a few files. Files changed: M .flake8 M .meta.toml Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@1f59b67 Explain the imports in Products/validation/validators/__init__.py Change the order, isort was complaining about most of the imports not being at the top. Files changed: M Products/validation/validators/__init__.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@c0a63bb Remove really unused imports. Files changed: M Products/validation/interfaces/IValidationService.py M Products/validation/service.py M Products/validation/tests/test_validation.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@faf4aa3 More flake8 fixes. Files changed: M Products/validation/chain.py M Products/validation/i18n.py M Products/validation/service.py M Products/validation/validators/ExpressionValidator.py M Products/validation/validators/SupplValidators.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:25+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@e1442f6 Fix left-over Python 2 constructs that do not work in Python 3. Files changed: M Products/validation/chain.py M Products/validation/validators/SupplValidators.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:26+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@68ca1db Drop support for Plone 5.2 and for Python 3.7 and lower. Only Plone 6.0 and 6.1 are supported now. Note that in Plone 6.1, this package is no longer tested together with the core. It has been moved to the ecosystem versions. Files changed: A news/60.breaking.1 M setup.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:26+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@5b000d0 Depend on Zope. Most other dependencies then get pulled in automatically. We could list them apart, but we already need Zope because we use OFS from that package. Files changed: M setup.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:26+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@cc394aa Removed `Products/validation/validators/validator.py`. This had backwards compatibility imports in a way that did not work on Python 3. So apparently no one needed this so far. Files changed: A news/60.breaking.2 D Products/validation/validators/validator.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T13:03:26+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@af24dc3 Dependencies: ignore Products.CMFPlone. We try an import of of its `utils.check_id`, but we always catch an ImportError, so the dependency is conditional. Files changed: M .meta.toml M pyproject.toml Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T15:06:08+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@326ad07 Remove check in tests for Plone 5.1. Files changed: M Products/validation/tests/test_validation.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T15:06:48+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@de7336c No, we don't want to fall back to pkgutil at any time. Files changed: M Products/__init__.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-12T15:14:37+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@bc47ad8 Split unit tests and doctests. This seems better and clearer anyway, and it avoids needing to call `makeSuite`, which would give: ``` DeprecationWarning: unittest.makeSuite() is deprecated and will be removed in Python 3.13. Please use unittest.TestLoader.loadTestsFromTestCase() instead. ``` Verbose output after this change, to check that no tests have gone missing: ``` $ tox -e test -- -vvv ... test: commands[0]> zope-testrunner --all --test-path=/Users/maurits/community/plone-coredev/6.0/src/Products.validation -s Products.validation -vvv Running tests at all levels Running zope.testrunner.layer.UnitTests tests: Set up zope.testrunner.layer.UnitTests in 0.000 seconds. Running: ExpressionValidator (Products.validation.validators.ExpressionValidator) (0.010 s) test_inNumericRange (Products.validation.tests.test_validation.TestValidation.test_inNumericRange) (0.000 s) test_isDecimal (Products.validation.tests.test_validation.TestValidation.test_isDecimal) (0.000 s) test_isEmail (Products.validation.tests.test_validation.TestValidation.test_isEmail) (0.000 s) test_isMailto (Products.validation.tests.test_validation.TestValidation.test_isMailto) (0.000 s) test_isPrintable (Products.validation.tests.test_validation.TestValidation.test_isPrintable) (0.000 s) test_isSSN (Products.validation.tests.test_validation.TestValidation.test_isSSN) (0.000 s) test_isURL (Products.validation.tests.test_validation.TestValidation.test_isURL) (0.000 s) test_isUSPhoneNumber (Products.validation.tests.test_validation.TestValidation.test_isUSPhoneNumber) (0.000 s) test_isUnixLikeName (Products.validation.tests.test_validation.TestValidation.test_isUnixLikeName) (0.000 s) test_isValidId_basic (Products.validation.tests.test_validation.TestValidation.test_isValidId_basic) (0.000 s) test_isValidId_fallback (Products.validation.tests.test_validation.TestValidation.test_isValidId_fallback) (0.001 s) test_isValidId_plone (Products.validation.tests.test_validation.TestValidation.test_isValidId_plone) (0.000 s) Ran 13 tests with 0 failures, 0 errors and 0 skipped in 0.013 seconds. Tearing down left over layers: Tear down zope.testrunner.layer.UnitTests in 0.000 seconds. test: OK (3.08=setup[2.12]+cmd[0.95] seconds) congratulations :) (3.18 seconds) ``` Files changed: A Products/validation/tests/test_doctests.py M Products/validation/tests/test_validation.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-14T15:07:01+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@0e4110a Cleanup new test_doctests.py. Files changed: M Products/validation/tests/test_doctests.py Repository: Products.validation Branch: refs/heads/master Date: 2024-08-14T17:23:50+02:00 Author: Maurits van Rees (mauritsvanrees) <[email protected]> Commit: plone/Products.validation@63a1fd8 Merge pull request #12 from plone/config-with-default-template-4b86f8f1 Drop support for Plone 5.2 and for Python 3.7 and lower Files changed: A .editorconfig A .flake8 A .github/workflows/meta.yml A .meta.toml A .pre-commit-config.yaml A Products/validation/tests/test_doctests.py A dependabot.yml A news/+meta.internal A news/60.breaking.1 A news/60.breaking.2 A tox.ini M .gitignore M CHANGES.rst M Products/__init__.py M Products/validation/ZService.py M Products/validation/__init__.py M Products/validation/chain.py M Products/validation/config.py M Products/validation/exceptions.py M Products/validation/i18n.py M Products/validation/interfaces/IValidationService.py M Products/validation/interfaces/IValidator.py M Products/validation/interfaces/__init__.py M Products/validation/service.py M Products/validation/tests/__init__.py M Products/validation/tests/test_validation.py M Products/validation/validators/BaseValidators.py M Products/validation/validators/EmptyValidator.py M Products/validation/validators/ExpressionValidator.py M Products/validation/validators/IdValidator.py M Products/validation/validators/RangeValidator.py M Products/validation/validators/RegexValidator.py M Products/validation/validators/SupplValidators.py M Products/validation/validators/__init__.py M docs/ChangeLog M pyproject.toml M setup.py D Products/validation/validators/validator.py D setup.cfg
- Loading branch information