Skip to content

Commit

Permalink
[fc] Repository: plone.scale
Browse files Browse the repository at this point in the history
Branch: refs/heads/master
Date: 2022-08-12T16:16:24+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.scale@85874eb

Use "scale" mode as default.

This cleans up more confusion between mode and direction.  See also plone/plone.namedfile#102.
Previously our definition of the `IImageScaleFactory` interface had the deprecated `direction="thumbnail"`.
Other parts used `mode="contain"` by default, which does cropping, where in Plone we are used to simple scaling almost everywhere.

Depending on your point of view, you could call this a bug fix (fixing the default to what Plone expects, to avoid surprises).
Or you could call this a breaking change, because the default changes.
It is beta stage, so I am okay with it either way.

Files changed:
A news/102.bugfix
M plone/scale/interfaces.py
M plone/scale/scale.py
M plone/scale/storage.py
M plone/scale/tests/test_scale.py
M plone/scale/tests/test_storage.py
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-09-29T12:34:49+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.scale@b1ba10f

No longer test Plone 5.2 on 3.6 and Plone 6.0 on 3.7.

Files changed:
A news/3637.breaking
M .github/workflows/tests.yml
M tox.ini
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-09-29T20:50:04+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.scale@79f2f13

Merge pull request #66 from plone/maurits-direction-versus-mode

Use "scale" mode as default.

Files changed:
A news/102.bugfix
A news/3637.breaking
M .github/workflows/tests.yml
M plone/scale/interfaces.py
M plone/scale/scale.py
M plone/scale/storage.py
M plone/scale/tests/test_scale.py
M plone/scale/tests/test_storage.py
M tox.ini
  • Loading branch information
mauritsvanrees committed Sep 29, 2022
1 parent 66fb5bd commit 77fc5cd
Showing 1 changed file with 61 additions and 15 deletions.
Loading

0 comments on commit 77fc5cd

Please sign in to comment.