Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid POSKeyError when commit occurs and we have savepoint that involves Plone Site #4026

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Avoid POSKeyError when commit occurs and we have savepoint that involves Plone Site #4026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63fd3a8
Avoid POSKeyError when commit occurs and we have savepoint that involves
wesleybl Oct 9, 2024
b3d5deb
Merge branch 'master' into poskeyerror
rohnsha0 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Products/CMFPlone/Portal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def __getattr__(self, name):

def __setattr__(self, name, obj):
# handle re setting an item as an attribute
if self._tree is not None and name in self:
if not name.startswith("_") and self._tree is not None and name in self:
Copy link
Member

@ale-rt ale-rt Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be more strict with this change and check for name.startswith("_p_") or name.startswith("_v_")?

del self[name]
self[name] = obj
else:
Expand Down
1 change: 1 addition & 0 deletions news/4026.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid POSKeyError when commit occurs and we have savepoint that involves Plone Site. @wesleybl