Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about interrupted conversion/dist-upgrade to stdout and motd #78

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

SandakovMM
Copy link
Contributor

No description provided.

@SandakovMM SandakovMM force-pushed the change-motd-on-signal branch 4 times, most recently from 23d5550 to d23abc7 Compare September 26, 2024 08:46
ukablan-wpc
ukablan-wpc previously approved these changes Sep 30, 2024
motd.add_finish_ssh_login_message("""
The dist-upgrade process was stopped by signal.
Please use the `--revert` option before trying again.
""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about mentioning about the program name?

@ukablan-wpc
Copy link
Contributor

Can you also share the console outputs when you try it?

@SandakovMM
Copy link
Contributor Author

Sure, no problem:

# ./centos2alma 
Doing preparation checks...
^CThe dist-upgrade process was stopped by signal 2. Please use the `centos2alma --revert` option before trying again.
# exit
logout
Connection to plesk-cos-7-1 closed.
~ [1]$ ssh root@XXX

===============================================================================
Message from the Plesk dist-upgrader tool:

    The dist-upgrade process was stopped by signal.
    Please use the `centos2alma --revert` option before trying again.
    You can remove this message from the /etc/motd file.
===============================================================================

@ukablan-wpc
Copy link
Contributor

Sure, no problem:

# ./centos2alma 
Doing preparation checks...
^CThe dist-upgrade process was stopped by signal 2. Please use the `centos2alma --revert` option before trying again.
# exit
logout
Connection to plesk-cos-7-1 closed.
~ [1]$ ssh root@XXX

===============================================================================
Message from the Plesk dist-upgrader tool:

    The dist-upgrade process was stopped by signal.
    Please use the `centos2alma --revert` option before trying again.
    You can remove this message from the /etc/motd file.
===============================================================================

Does it revert motd message when we revert?

@SandakovMM
Copy link
Contributor Author

Yes. --revert restores motd file from backup

@SandakovMM SandakovMM merged commit b2c1bbf into main Oct 4, 2024
3 checks passed
@SandakovMM SandakovMM deleted the change-motd-on-signal branch October 4, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants