Removed lock file upon receiving interrupt signals #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpushkaryov
suggested changes
Sep 10, 2024
pleskdistup/main.py
Outdated
| @@ -581,6 +593,10 @@ def main(): | |||
| printerr(f"{util_name} is ongoing. To check its status, please use `--monitor` or `--status`") | |||
| return 1 | |||
|
|
|||
| exit_signal_handler = create_free_lock_exit_signal_handler(lock_file) | |||
| for signum in (signal.SIGINT, signal.SIGTERM, signal.SIGHUP, signal.SIGABRT, signal.SIGSEGV): | |||
There was a problem hiding this comment.
signal documentation states that it makes little sense to catch SIGSEGV.
pleskdistup/main.py
Outdated
| def signal_handler(signum, frame): | ||
| log.info(f"Received signal {signum}, going to free lockfile {lock_file!r}...") | ||
| try: | ||
| os.unlink(lock_file) |
There was a problem hiding this comment.
I suspect it could cause double unlink with try_lock(), producing spurious warning in log, because sys.exit() will just raise SystemExit somewhere on the main thread, so try_lock() exit procedure will be executed too.
There was a problem hiding this comment.
It actually simplifies things a lot, thx
kpushkaryov
approved these changes
Sep 11, 2024
…s upon receiving signals
SandakovMM
force-pushed
the
free-lock-on-signals
branch
from
f7aa6d0
to
8959277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.