Handle kernel versions with '_' before build number #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpushkaryov
suggested changes
Mar 5, 2024
kpushkaryov
previously approved these changes
Mar 7, 2024
| def test_kernel_with_underline(self): | ||
| kernel = version.KernelVersion("kernel-3.14.43_1-2.x86_64") | ||
| self.assertEqual(str(kernel), "3.14.43-1.2.x86_64") | ||
| self.assertEqual(kernel.major, "3") |
There was a problem hiding this comment.
I suggest to expand other tests in the same way later.
There was a problem hiding this comment.
Please rebase before merge.
SandakovMM
force-pushed
the
fix-kernel-version-with-underlining
branch
from
240dab6
to
e407ac9
Compare
SandakovMM
force-pushed
the
fix-kernel-version-with-underlining
branch
from
e407ac9
to
0a798c8
Compare
|
@kpushkaryov Could you please approve once again. Changes from other commit leaked into the branch, so I have to remove it and re-base once again. |
kpushkaryov
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.