update products when sales is disabled #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: app/views/spree/shared/_original_price_display_item_added.html.erb
modified: app/helpers/spree/products_helper_decorator.rb
…tewide Spree sale pricing sitewide
…g into 2-3-stable
create 2-3-stable branch
…the function of this plugin that has diverged in the community a fair bit. This commit incorporates work that allows the plugin to function properly for sale items. The major issue is that Variants were not correctly announcing themselves as on_sale?=true When the 'price' was being copied to a line item it was always copied as a the full item price because on_sale? would always report false. This set of fixes allows the variant to correctly report its status.
Big ole stinking hacky fix of a merge of open source work to improve the...
Fix show percentage savings on cart page
…al price line-through modified: app/overrides/add_original_price_to_products_index.rb modified: app/views/spree/shared/_original_price_display.html.erb modified: app/views/spree/shared/_original_price_display_item_added.html.erb modified: app/views/spree/shared/_original_price_display_variant.html.erb
modified: spree_sale_pricing.gemspec
…g-with-multiple-variants Add original price override to variant-listing
2 3 stable
Put variants on sale
2 3 stable
new file: app/overrides/add_original_price_to_variant_options.rb new file: app/views/spree/shared/_original_price_display_variant_options.html.erb
modified: app/views/spree/shared/_original_price_display_variant_options.html.erb modified: spree_sale_pricing.gemspec
Add sale pricing to detailed spotlight
Use lowest price rather than last created
…g into per_line_item_action
Per line item action
version bump to 0.3.11
|
@kascote this also needs to be opened against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericsaupe, @jeffreyfuchang