Close the lock file in pexes when we're doing (#236)

please-build · Dec 13, 2024 · 397ea0c · 397ea0c
1 parent 2ab13c9
commit 397ea0c
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/tools/please_pex/pex/pex_main.py b/tools/please_pex/pex/pex_main.py
@@ -62,12 +62,12 @@ def explode_zip():
     def pex_lockfile(basepath, uniquedir):
         # Acquire the lockfile.
         lockfile_path = os.path.join(basepath, '.lock-%s' % uniquedir)
-        lockfile = open(lockfile_path, "a+")
-        # Block until we can acquire the lockfile.
-        portalocker.lock(lockfile, portalocker.LOCK_EX)
-        lockfile.seek(0)
-        yield lockfile
-        portalocker.lock(lockfile, portalocker.LOCK_UN)
+        with open(lockfile_path, "a+") as lockfile:
+            # Block until we can acquire the lockfile.
+            portalocker.lock(lockfile, portalocker.LOCK_EX)
+            lockfile.seek(0)
+            yield lockfile
+            portalocker.lock(lockfile, portalocker.LOCK_UN)
 
     @contextlib.contextmanager
     def _explode_zip():