#215 Add followRedirects support to the Akka Http backend #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jan 24, 2018
| return CompletableFuture.completedFuture(response); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we move this into Akka itself? even if only working on the high level API it'd be nice anyway to have it there?
cc @jrudolph
jrudolph
reviewed
Jan 30, 2018
| if (redirectsLeft < 1) { | ||
| Future.failed(new IllegalStateException("Maximum redirect reached: " + MaxRedirects)) | ||
| } else if (response.status.isRedirection() && config.followRedirects) { | ||
| val location = response.header[Location].get.uri |
There was a problem hiding this comment.
Probably needs explicit handling of missing Location header to improve the error message in that case.
jrudolph
reviewed
Jan 30, 2018
| val redirectUri = | ||
| if (location.isRelative) | ||
| if (location.path.startsWithSlash) | ||
| request.uri.withPath(location.path) |
There was a problem hiding this comment.
You could use location.resolveAgainst(request.uri) instead.
|
Closing the akka-http backend related tickets for now. These will be handled in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds followRedirects support to the Akka Http backend.
While adding tests for the followRedirects functionality I noticed some inconsistent behaviour of the Ahc backend. Therefore some of the tests are marked as pending for the Ahc backend.
This PR builds on top of #227 (which builds on top of #208 in itself) and therefore should be rebased and retargeted to master after #227 is merged.
Fixes #215