Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.10.x] Revert "sbt-scalajs, scalajs-compiler, ... 1.16.0 (was 1.15.0)" #1020

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Apr 29, 2024

Reverts #1006

We did not merge this in twirl, so let's do the same for play-json, see comments starting here: playframework/twirl#750 (comment)

@mkurz mkurz force-pushed the revert-1006-update/2.10.x/sbt-scalajs-1.16.0 branch from bc78456 to 09b653e Compare April 29, 2024 13:11
@mkurz mkurz force-pushed the revert-1006-update/2.10.x/sbt-scalajs-1.16.0 branch from 09b653e to 49b7485 Compare April 30, 2024 07:20
@@ -146,7 +146,7 @@ lazy val `play-json` = crossProject(JVMPlatform, JSPlatform, NativePlatform)
libraryDependencies ++= Seq(
"org.scalatest" %%% "scalatest" % "3.2.18" % Test,
"org.scalatestplus" %%% "scalacheck-1-16" % "3.2.14.0" % Test,
"org.scalacheck" %%% "scalacheck" % "1.17.1" % Test,
"org.scalacheck" %%% "scalacheck" % "1.17.0" % Test,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to downgrade because scalacheck patch release upgraded to sbt-scalajs 1.16 which is incompatible: typelevel/scalacheck@8caf0b1

@mkurz mkurz merged commit c1b687f into 2.10.x Apr 30, 2024
14 checks passed
@mkurz mkurz deleted the revert-1006-update/2.10.x/sbt-scalajs-1.16.0 branch April 30, 2024 07:55
@mkurz mkurz changed the title Revert "sbt-scalajs, scalajs-compiler, ... 1.16.0 (was 1.15.0)" [2.10.x] Revert "sbt-scalajs, scalajs-compiler, ... 1.16.0 (was 1.15.0)" Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant