Fixed: make sure 'Connect' button status is correct with valid/invali…

…d values and/or page reloads.
plausible · May 21, 2024 · 6cb2bba · 6cb2bba
1 parent f26ab89
commit 6cb2bba
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/assets/src/js/admin/main.js b/assets/src/js/admin/main.js
@@ -149,7 +149,10 @@ document.addEventListener('DOMContentLoaded', () => {
 			form.append('options', JSON.stringify(options));
 			form.append('_nonce', plausible.nonce);
 
-			button.children[0].classList.remove('hidden');
+			if (button.children.length > 0) {
+				button.children[0].classList.remove('hidden');
+			}
+
 			button.setAttribute('disabled', 'disabled');
 
 			plausible.ajax(form, button);
@@ -330,8 +333,15 @@ document.addEventListener('DOMContentLoaded', () => {
 				}
 			).then(response => {
 				if (button) {
-					button.children[0].classList += ' hidden';
-					button.removeAttribute('disabled');
+					if (button.children.length > 0) {
+						button.children[0].classList += ' hidden';
+					}
+
+					if (button.id === 'connect_plausible_analytics' && response.status === 200) {
+						button.innerText = plausible_analytics_i18n.connected;
+					} else {
+						button.removeAttribute('disabled');
+					}
 				}
 
 				if (response.status === 200) {

diff --git a/assets/src/js/admin/main.min.js b/assets/src/js/admin/main.min.js