fixing currency parse invalid value with decimal arguments

platformbuilders · Jul 30, 2020 · 14db3dd · 14db3dd
1 parent 6eb35ec
commit 14db3dd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@platformbuilders/helpers",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "Platfom builders helpers library",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/__tests__/currencyParser.spec.ts b/src/__tests__/currencyParser.spec.ts
@@ -6,6 +6,10 @@ describe('currencyParser tests', () => {
       const parsed = currencyParser('abc');
       expect(parsed).toBe('R$ 0,00');
     });
+    it('should format currency properly if value has only letters and consider number of decimals', () => {
+      const parsed = currencyParser('abc', 0);
+      expect(parsed).toBe('R$ 0');
+    });
 
     it('should format currency properly if value has letters and numbers', () => {
       const parsed = currencyParser('1k');

diff --git a/src/currencyParser.ts b/src/currencyParser.ts
@@ -5,17 +5,18 @@ export const currencyParser = (
   value: string | number,
   numberOfDecimalPlaces = NUMBER_OF_DECIMAL_PLACES_DEFAULT,
 ): string => {
+  let formatValue = value;
   const isValidValue = regex.test(String(value));
   const decimals =
     numberOfDecimalPlaces < 0
       ? NUMBER_OF_DECIMAL_PLACES_DEFAULT
       : numberOfDecimalPlaces;
 
   if (!isValidValue) {
-    return 'R$ 0,00';
+    formatValue = 0;
   }
 
-  const withDecimalValue = Number(value)
+  const withDecimalValue = Number(formatValue)
     .toFixed(decimals)
     .replace('.', ',')
     .replace(/(\d)(?=(\d{3})+,)/g, '$1.');