feat: open deploy to take package-names
#35
+155
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemellander
force-pushed
the
km/open-deploy-to-packages
branch
from
24471e2 to
9c802bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deploy package currently only deploys one package at a time. We are moving to a world where monorepos can deploy to multiple packages and we need the deploy action to allow for this behavior.
The big change is that deploy depends on package_names instead of package_name. If you send in package_name, it will set package_names as
[package_name]. Other than that, the only other changes are some minor changes to wording to accommodate multiple packages.