Skip to content

Commit

Permalink
Revert "Upgrade to plexus-build-api 1.1.0"
Browse files Browse the repository at this point in the history
The current  Eclipse we're using is still based on the sonatype code base.

In Eclipse, with ecj, the patch generates an error that it clearly does not
do on javac/gradle.

@gnodet, can you take a look?

This reverts commit 2443973.

---
 Signed-off-by: Peter Kriens <[email protected]>
  • Loading branch information
pkriens committed Jun 1, 2023
1 parent 0d1e8fe commit 8d46218
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bndtools.m2e/bnd.bnd
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
org.eclipse.m2e.core,\
org.eclipse.m2e.jdt,\
org.eclipse.osgi,\
org.codehaus.plexus:plexus-build-api
org.sonatype.plexus:plexus-build-api

Bundle-SymbolicName: ${p};singleton:=true
Bundle-ActivationPolicy: lazy
Expand Down
2 changes: 1 addition & 1 deletion bndtools.test/tester/cnf/ext/repositories.bnd
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ mavencentral: https://repo.maven.apache.org/maven2
cache="${workspace}/cnf/cache/stable/Eclipse-2018-12",\
aQute.bnd.repository.maven.pom.provider.BndPomRepository;\
name="Eclipse m2e 1.10.0 Dependencies";\
revision="org.apache.maven:maven-core:3.5.3,org.apache.maven:maven-aether-provider:3.3.9,org.codehaus.plexus:plexus-build-api:1.1.0";\
revision="org.apache.maven:maven-core:3.5.3,org.apache.maven:maven-aether-provider:3.3.9,org.sonatype.plexus:plexus-build-api:0.0.7";\
releaseUrls="${mavencentral}";\
location="${workspace}/cnf/cache/stable/Eclipse-m2e-1.10.0/index.xml"

Expand Down
2 changes: 1 addition & 1 deletion cnf/ext/central.mvn
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,6 @@ org.apache.maven:maven-plugin-api:${maven.target.version}
org.apache.maven:maven-repository-metadata:${maven.target.version}
org.apache.maven:maven-settings:${maven.target.version}
org.eclipse.aether:aether-api:${aether.version}
org.codehaus.plexus:plexus-build-api:1.1.0
org.sonatype.plexus:plexus-build-api:0.0.7
org.codehaus.plexus:plexus-utils:3.0.22
org.codehaus.plexus:plexus-classworlds:2.5.2
2 changes: 1 addition & 1 deletion maven-plugins/bnd-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<artifactId>maven-mapping</artifactId>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<groupId>org.sonatype.plexus</groupId>
<artifactId>plexus-build-api</artifactId>
</dependency>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
import org.codehaus.plexus.util.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.codehaus.plexus.build.BuildContext;
import org.sonatype.plexus.build.incremental.BuildContext;

/**
* Abstract base class for all bnd-maven-plugin mojos.
Expand Down
4 changes: 2 additions & 2 deletions maven-plugins/bnd-plugin-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<groupId>org.sonatype.plexus</groupId>
<artifactId>plexus-build-api</artifactId>
<version>1.1.0</version>
<version>0.0.7</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand Down
2 changes: 1 addition & 1 deletion maven-plugins/bnd-reporter-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<artifactId>maven-mapping</artifactId>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<groupId>org.sonatype.plexus</groupId>
<artifactId>plexus-build-api</artifactId>
</dependency>
<dependency>
Expand Down

3 comments on commit 8d46218

@gnodet
Copy link

@gnodet gnodet commented on 8d46218 Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, sorry about that. I realized that after you merged, see eclipse-m2e/m2e-core#944

@pkriens
Copy link
Owner Author

@pkriens pkriens commented on 8d46218 Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading Eclipse will be a big deal for us ... any idea when that would become important?

@gnodet
Copy link

@gnodet gnodet commented on 8d46218 Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://issues.sonatype.org/projects/OSSRH/issues/OSSRH-91969
Given the problematic upgrade, I've tagged a 0.8.0 of the old plexus-build-api with the required change, but I can't really upload it for now.
When that's sorted, I'll create a new PR to upgrade to that one, which should be a breeze ...

Please sign in to comment.