-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jaino/#93 #96
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a6b4a18
[CHORE] #93 : SurveyForm Entity ์์ add SurveyFormId
jeongjaino c4e2146
[CHORE] #93 : ์ค๋ฌธ ํ์ ๋ถ๋ฌ์ฌ ๋ / EventId -> SurveyFormId๋ก ์ธ์ ๋ณ๊ฒฝ
jeongjaino 56477cc
[CHORE] #93 : ์ค๋ฌธ ํ์(SurveyForm) ์ ์ฅ ๋ก์ง ์์
jeongjaino 008dae6
[CHORE] #93 : ์ค๋ฌธ ํ์(SurveyForm) ์ ์ฅ ๋ก์ง ์์
jeongjaino 3c9b0c1
[CHORE] #93 : ์ค๋ฌธ (Survey) Entity ์์ / + SurveyFormId
jeongjaino 407dcdd
[CHORE] #93 : ์ค๋ฌธ (Survey) Entity ์์ / + SurveyFormId
jeongjaino 3071c63
[CHORE] #93 : EventId๋ฅผ ํตํด ์กฐํ -> SurveyFormID๋ก ์์
jeongjaino 6bdd67a
[CHORE] #93 : Indicator ์ปดํฌ๋ํธ ๋ถ๋ฆฌ
jeongjaino 3959e78
[UI] #93 : Bottom Button ํ๋จ padding ์ ์ฉ
jeongjaino bca1af2
[FEATURE] #93 : SurveyForm ์
๋ฐ์ดํธ ๋ก์ง ๊ตฌํ
jeongjaino 21a3633
[FEATURE] #93 : SurveyForm ์
๋ฐ์ดํธ ์ ์ค์ผ์ด์ค ๊ตฌํ
jeongjaino f9765ac
[FEATURE] #93 : ์ค๋ฌธ ํ์ ์์ Screen ๋ฐ ViewModel ๊ตฌํ
jeongjaino 5ff4718
[FEATURE] #93 : Management - Survey Navigation ๊ตฌํ SurveyForm (Registrโฆ
jeongjaino e082dd5
[FEATURE] #93 : ๊ด๋ฆฌ ํญ์์ ์ค๋ฌธ ํด๋ฆญ์ / ์์ฑ๋ ์ค๋ฌธ -> ์ค๋ฌธํ์ ์์ ์ผ๋ก ๋ณ๊ฒฝ
jeongjaino bff7d87
[CHORE] #93 : management-survey/registration -> management-survey๋ก paโฆ
jeongjaino 4a31f18
[CHORE] #93 : ๊ธฐ์กด survey -> surveyForm์ผ๋ก ์ด๋ฆ ๋ณ๊ฒฝ
jeongjaino 11be809
[STYLE] #93 : ์ฝ๋ ํฌ๋งทํ
์์
jeongjaino 2401d21
[FIX] #93 : LazyColumn ๊ฐ ์์ดํ
๊ณ ์ ํค ๊ฐ eventid -> surveyFormId๋ก ๋ณ๊ฒฝ
jeongjaino 2d48103
[CHORE] #93 : String Resource ์ถ๊ฐ
jeongjaino 0aca95c
Merge branch 'develop' of https://github.com/pknu-wap/WAPP into featuโฆ
jeongjaino e7cfa84
[STYLE] #93 : ๋ฆฐํธ Formatting ์์
jeongjaino a8072cb
[FEATURE] #93 : setSurveyRegistrationState ํจ์ ์ธ๋ถํ
jeongjaino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 12 additions & 2 deletions
14
core/data/src/main/java/com/wap/wapp/core/data/repository/survey/SurveyFormRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,21 @@ | ||
package com.wap.wapp.core.data.repository.survey | ||
|
||
import com.wap.wapp.core.model.survey.SurveyForm | ||
import com.wap.wapp.core.model.survey.SurveyQuestion | ||
import java.time.LocalDateTime | ||
|
||
interface SurveyFormRepository { | ||
suspend fun getSurveyForm(eventId: String): Result<SurveyForm> | ||
suspend fun getSurveyForm(surveyFormId: String): Result<SurveyForm> | ||
|
||
suspend fun getSurveyFormList(): Result<List<SurveyForm>> | ||
|
||
suspend fun postSurveyForm(surveyForm: SurveyForm): Result<Unit> | ||
suspend fun postSurveyForm( | ||
eventId: String, | ||
title: String, | ||
content: String, | ||
surveyQuestionList: List<SurveyQuestion>, | ||
deadline: LocalDateTime, | ||
): Result<Unit> | ||
|
||
suspend fun updateSurveyForm(surveyForm: SurveyForm): Result<Unit> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
core/domain/src/main/java/com/wap/wapp/core/domain/usecase/survey/UpdateSurveyFormUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package com.wap.wapp.core.domain.usecase.survey | ||
|
||
import com.wap.wapp.core.data.repository.survey.SurveyFormRepository | ||
import com.wap.wapp.core.model.survey.SurveyForm | ||
import javax.inject.Inject | ||
|
||
class UpdateSurveyFormUseCase @Inject constructor( | ||
private val surveyFormRepository: SurveyFormRepository, | ||
) { | ||
suspend operator fun invoke(surveyForm: SurveyForm): Result<Unit> = runCatching { | ||
surveyFormRepository.updateSurveyForm(surveyForm) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ณ ๊ฑด์๋๋ฐ,
ํ์ด์ด๋ฒ ์ด์ค ์ฌ์ฉํ ๋ default value์ฃผ๋ ๊ฑฐ๋ ๋ถ ์์ฑ์๋ก ์ ์ธํ๋ ๊ฑฐ๋ ์ฐจ์ด์ ์ด ์๋์ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ํํ ๋ด๋ถ์ ์ผ๋ก๋ ์ด๋ป๊ฒ ์ฐจ์ด์ ์ด ์๋์ง๋ ์ ๋ชจ๋ฅด๊ฒ ์ต๋๋ค ใ .ใ
์ ๊ฐ Default๊ฐ ์๋ ๋ฐ๋ก ์์ฑ์๋ฅผ ์ฌ์ฉํ๋ ์ด์ ๋
๋จ์ํ ๋ํดํธ๋ณด๋ค ๋ถ ์์ฑ์๊ฐ ์ฝ๋์ ๊น๋ํด๋ณด์ฌ์, ๋งค๋ฒ ์ด๋ ๊ฒ ์์ฑํ๊ณ ์์ต๋๋ค .. !
์ฝ๋ ๋์ผ๋ก ๋ดค์ ๋๋ ๋ํดํธ๊ฐ ๋ ์ ๊ฒ ์์ฑ๋๊ธด ํ๊ฒ ๋ค์ฉ ํํ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ทธ๋๋ ์๋ง ์ฝํ๋ฆฐ์์ ๋ถ ์์ฑ์๊ฐ ๋ํดํธ ๊ฐ์ ์ญํ ๋ ํ๊ธฐ ๋๋ฌธ์,
๋ด๋ถ์ ์ผ๋ก๋ ์๋ง ๊ฐ๊ฒ ๋์ํ์ง ์์๊น์ ?