Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featurejaino/#14 #19

Closed
wants to merge 17 commits into from
Closed

Featurejaino/#14 #19

wants to merge 17 commits into from

Conversation

jeongjaino
Copy link
Member

@jeongjaino jeongjaino commented Oct 5, 2023 •
edited
Loading

1. 📄 관련된 이슈 및 소개

#14 Firebase Github 로그인 로직 구현

2. 🔥변경된 점

FirebaseAuth를 활용한 Github 로그인 로직 구현

  1. hasPandingResult -> 백그라운드로 로그인이 처리되는데, 현재 백그라운드에 처리중인 로직이 있는지 체크 함수
  2. signIn -> github auth를 이용한 FirebaseAuth 로그인 로직 구현
  3. hilt, ksp 종속성 / 플러그인 추가 및 셋업
  4. 모듈 추가 domain, model, network

3. 📸 스크린샷(선택)

4. 💡알게된 혹은 궁금한 사항들

@jeongjaino jeongjaino added the 🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다. label Oct 5, 2023
@jeongjaino jeongjaino requested a review from tgyuuAn October 5, 2023 03:40
@jeongjaino jeongjaino self-assigned this Oct 5, 2023
@jeongjaino jeongjaino closed this Oct 5, 2023
@jeongjaino jeongjaino reopened this Oct 5, 2023
@jeongjaino jeongjaino closed this Oct 5, 2023
@jeongjaino jeongjaino reopened this Oct 5, 2023
@jeongjaino jeongjaino closed this Oct 5, 2023
@jeongjaino jeongjaino reopened this Oct 5, 2023
@jeongjaino jeongjaino closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgyuuAn tgyuuAn Awaiting requested review from tgyuuAn

Assignees

@jeongjaino jeongjaino

Labels
🔥리뷰 기다리는 중🔥 PR을 올리고 코드리뷰를 기다리고 있는 상태입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeongjaino