Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jaino/#128 #144

Merged
merged 21 commits into from
Feb 27, 2024
Merged

Feature/jaino/#128 #144

merged 21 commits into from
Feb 27, 2024

Conversation

jeongjaino
Copy link
Member

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

#128 ์„ค๋ฌธ ์ด์ „ ๋ฒ„ํŠผ ํด๋ฆญ์‹œ ์Œ๋‹ต ๊ฒ€์ฆ ๋ฐ ์ƒํƒœ ์ €์žฅ

2. ๐Ÿ”ฅ ๋ณ€๊ฒฝ๋œ ์ 

  1. ์„ค๋ฌธ ์ด์ „ ๋ฒ„ํŠผ์„ ํด๋ฆญํ•˜๋ฉด ์ƒํƒœ๋ฅผ ์ €์žฅํ•ฉ๋‹ˆ๋‹ค.
  2. ์„ค๋ฌธ ๋“ฑ๋ก์‹œ (์šด์˜์ง„) ๋งˆ์ง€๋ง‰ ๋ฒ„ํŠผ ํ…์ŠคํŠธ๊ฐ€ "๋‹ค์Œ"์—์„œ "์„ค๋ฌธ ๋“ฑ๋ก"์œผ๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  3. ์„ค๋ฌธ ์ž‘์„ฑ์‹œ ๋’ค๋กœ๊ฐ€๊ธฐ ๋ฒ„ํŠผ์ด close ๋ฒ„ํŠผ์œผ๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

3. โœ… ๊ผญ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ๋ถ€๋ถ„

์ค€์„ฑ๋‹˜์ด ์–ธ๊ธ‰ํ•ด์ฃผ์‹  QA
ํšŒ์›์ด ์„ค๋ฌธ ์ž‘์„ฑํ•  ๋•Œ, ์„ค๋ฌธ Validation์ด ํ†ต๊ณผ๋˜์ง€ ์•Š์•˜๋Š”๋ฐ ๋’ค๋กœ๊ฐ€๊ธฐ ๋ฒ„ํŠผ์ด ์ˆ˜ํ–‰๋œ๋‹ค.

๋ฅผ ์ˆ˜์ •ํ•˜๋ ค๊ณ  ํ–ˆ๋Š”๋ฐ, ์‚ฌ์‹ค ์ œ๊ฐ€ ์ฒ˜์Œ ๊ฐœ๋ฐœํ•  ๋•Œ ๊ทธ๊ฒŒ ์˜๋„์˜€์–ด์š”.
๋’ค๋กœ๊ฐ€๊ธฐ์—๋Š” ์›๋ž˜ Validation์ด ์—†์–ด์š”. ๊ทธ๋ž˜์„œ ์‘๋‹ต ๋ชฉ๋ก์—๋„ Validation์ด ์ง€์ผœ์ง€์ง€ ์•Š์€ ์ฑ„๋กœ ์‘๋‹ต์ด ๋“ค์–ด๊ฐˆ ์ˆ˜ ์žˆ์–ด์š”

ํ•˜์ง€๋งŒ, ์•ž์œผ๋กœ๊ฐ€๊ธฐ๊ฐ€ ์•ˆ๋ผ์š”. ๋‹ค์Œ ๋ฒ„ํŠผ์ด๋‚˜ ์ œ์ถœ๋ฒ„ํŠผ์„ ๋ˆ„๋ฅด๋ ค๋ฉด, Validation์„ ๊ฒ€์ฆํ•ด์•ผํ•ด์š”.
๋”ฐ๋ผ์„œ ์ „์ฒด์ ์œผ๋กœ Validation์ด ์ง€์ผœ์ง„ ์‘๋‹ต ๋ชฉ๋ก์„ ๊ฐ€์งˆ ์ˆ˜ ์žˆ์–ด์š”

์‹ค์ œ๋กœ ์‚ฌ์šฉํ•ด๋ณด์‹œ๋ฉด ์‚ฌ์šฉ์ž ์ธก๋ฉด์—์„œ ์ฒด๊ฐ์ด ๋ ๊บผ์—์š”.
๋’ค๋กœ๊ฐ€๊ธฐ๋ฅผ ํ•˜๊ณ  ์‹ถ์€๋ฐ, ํ˜„์žฌ ์‘๋‹ต์„ Validation์ด ์ˆ˜ํ–‰๋˜์–ด์•ผ ๋’ค๋กœ ๋Œ์•„๊ฐ€๋Š” ๊ฒƒ๊ณผ
ํ˜•์‹์ด ์ง€์ผœ์ง€์ง€ ์•Š์•„๋„ ๋’ค๋กœ๊ฐ€๊ธฐ๊ฐ€ ์ˆ˜ํ–‰๋˜๋Š” ์ฐจ์ด์š”.

๊ทผ๋ฐ ์ค€์„ฑ๋‹˜ QA ๋•๋ถ„์— ์—„์ฒญ ํฐ ๋ฌธ์ œ๋ฅผ ๋ฐœ๊ฒฌํ–ˆ์–ด์š”.
์ด์ „ ๋ฒ„ํŠผ์„ ๋ˆŒ๋ €์„ ๋•Œ, Validation์€ ์ˆ˜ํ–‰์ด ์•ˆ๋˜์–ด๋„ ์‘๋‹ต์€ ์ €์žฅ๋˜์–ด์•ผํ•˜๊ฑฐ๋“ ์š”
์ค‘์š”ํ•œ ์‘๋‹ต์„ ์ €์žฅํ•˜๋Š” ๋กœ์ง์ด ๋น ์กŒ์—ˆ์–ด์š” !

๊ทธ๋ž˜์„œ ์ด๋ฒˆ ํ”ผ์•Œ์— ๋’ค๋กœ๊ฐ€๊ธฐ์‹œ ์‘๋‹ต์„ ์ €์žฅํ•˜๋Š” ๋กœ์ง์„ ์ถ”๊ฐ€ํ–ˆ์–ด์š”. (Validation์„ ๊ฒ€์ฆํ•˜์ง€ ์•Š์•„๋„)

์ œ๊ฐ€ ์—ฌ๋Ÿฌ๋ฒˆ ํ…Œ์ŠคํŠธํ•˜๊ณ , ์ƒ๊ฐํ–ˆ์„ ๋–„๋Š” ๋ฌธ์ œ๊ฐ€ ์—†์—ˆ๋Š”๋ฐ
ํƒœ๊ทœ์ƒ์ด ์ƒ๊ฐํ•˜์‹œ๋Š” ๋ฌธ์ œ๊ฐ€ ์žˆ์œผ์‹œ๋ฉด ๋‹ต๋ณ€์ฃผ์„ธ์š” ! (์ดํ•ดํ•˜์…จ์„์ง€ ๋ชจ๋ฅด๊ฒ ๋„ค์š” ํ•˜ํ•˜,, =์ดํ•ด์•ˆ๋˜์‹œ๋ฉด ๋””์ฝ” ๋‹ฌ๋ ค๊ฐˆ๊ฒŒ์š”)

4. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

Screen_recording_20240227_210413.webm

5. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

โ€ฆre/jaino/#95

# Conflicts:
#	app/src/main/java/com/wap/wapp/MainActivity.kt
#	feature/survey/src/main/java/com/wap/wapp/feature/survey/answer/SurveyAnswerForm.kt
โ€ฆre/jaino/#95

# Conflicts:
#	app/src/main/java/com/wap/wapp/MainActivity.kt
#	feature/management/src/main/java/com/wap/wapp/feature/management/ManagementScreen.kt
โ€ฆ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๊ฒŒ ์•„๋‹Œ ์ธ์ž๋กœ ๋„˜๊ธด ์ƒํƒœ๋กœ ๋ณ€๊ฒฝ๋˜๋„๋ก ์ˆ˜์ •
โ€ฆ ํ˜„์žฌ ๋ฐ ๋‹ค์Œ ์ƒํƒœ ์ธ์ž๋กœ ๋„˜๊ฒจ์ฃผ๊ธฐ
@jeongjaino jeongjaino added ๐Ÿš€์ง„ํ˜ธ๐Ÿš€ ESTP ์ •์ง„ํ˜ธ 23์„ธ ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. ๐Ÿ”จํ”ฝ์Šค๐Ÿ”จ ๋ฒ„๊ทธ ๋ฐ ์ž ์žฌ์  ๋ฌธ์ œ ํ•ด๊ฒฐ labels Feb 27, 2024
@jeongjaino jeongjaino self-assigned this Feb 27, 2024
Copy link
Member

@tgyuuAn tgyuuAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ง„ํ˜ธ์ƒ LGTM์ด์—์š”~~

์ง„ํ˜ธ๋‹˜์ด ์˜ฌ๋ ค๋†“์œผ์‹  ์˜์ƒ์ด ๋งž๋Š” ๊ฒƒ ๊ฐ™๊ธดํ•˜๋„ค์š”.

๊ทผ๋ฐ ํ•œ ๊ฐ€์ง€ ๊ถ๊ธˆํ•œ ๊ฒŒ ์žˆ๋Š”๋ฐ,

์งˆ๋ฌธ ์ถ”๊ฐ€ ๋ฒ„ํŠผ์„ ๋ˆ„๋ฅด๋ฉด ๋ฌด์กฐ๊ฑด ์งˆ๋ฌธ์„ ๋งŒ๋“ค์–ด์•ผ ํ•˜๋‚˜์š”?

๋˜๋Œ๋ฆฌ๊ธฐ๊ฐ€ ์•ˆ๋˜๋‚˜์š”? ๊ทธ๊ฒŒ ๊ทธ #117 (comment) ์ด์Šˆ ์ธ๊ฐ€...?!

Comment on lines 138 to 142
val startDate = _eventStartDate.value
val endDate = _eventEndDate.value

if (startDate == endDate) {
return eventTime > _eventStartTime.value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •๋ง ๋ฏธ์„ธ ๋จผ์ง€๊ธด ํ•œ๋ฐ,

eventStartTime๋งŒ ๋ณ€์ˆ˜๋กœ ์•ˆ ๋นผ๊ณ  value๋กœ ์ ‘๊ทผํ•˜๋‹ˆ ์•ฝ๊ฐ„ ์ด์งˆ๊ฐ(?)์ด ๋“œ๋Š” ๋Š๋‚Œ?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ ํƒœ๊ทœ์ƒ ์ œ๋Œ€๋กœ ๋ณด์…จ๋„ค์š” ์ €๋Š” ๋ชป์•Œ์•„์ฐจ๋ ธ์–ด์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค์ž‡!

@tgyuuAn tgyuuAn added ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. and removed ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Feb 27, 2024
@jeongjaino
Copy link
Member Author

jeongjaino commented Feb 27, 2024

์ง„ํ˜ธ์ƒ LGTM์ด์—์š”~~

์ง„ํ˜ธ๋‹˜์ด ์˜ฌ๋ ค๋†“์œผ์‹  ์˜์ƒ์ด ๋งž๋Š” ๊ฒƒ ๊ฐ™๊ธดํ•˜๋„ค์š”.

๊ทผ๋ฐ ํ•œ ๊ฐ€์ง€ ๊ถ๊ธˆํ•œ ๊ฒŒ ์žˆ๋Š”๋ฐ,

์งˆ๋ฌธ ์ถ”๊ฐ€ ๋ฒ„ํŠผ์„ ๋ˆ„๋ฅด๋ฉด ๋ฌด์กฐ๊ฑด ์งˆ๋ฌธ์„ ๋งŒ๋“ค์–ด์•ผ ํ•˜๋‚˜์š”?

๋˜๋Œ๋ฆฌ๊ธฐ๊ฐ€ ์•ˆ๋˜๋‚˜์š”? ๊ทธ๊ฒŒ ๊ทธ #117 (comment) ์ด์Šˆ ์ธ๊ฐ€...?!

๋„ค ํƒœ๊ทœ์ƒ ์ง€๊ธˆ ๋‹น์žฅ์€ ๊ทธ๋ ‡์Šต๋‹ˆ๋‹ค.

๊ทธ๋ž˜์„œ ํ•ญ๋ชฉ์ถ”๊ฐ€๋ฅผ ํ•˜๋ฉด ๋ฌด์กฐ๊ฑด ์งˆ๋ฌธ์„ ๋งŒ๋“ค์–ด์•ผ ํ•ด์š”.

๊ทธ๋ž˜์„œ ์‚ญ์ œ ๊ธฐ๋Šฅ์ด ํ•„์š”ํ•œ๊ฑฐ๊ธฐ๋„ ํ•˜๊ณ ์š” ๐Ÿ˜†

@jeongjaino jeongjaino merged commit f2e53e3 into develop Feb 27, 2024
@tgyuuAn tgyuuAn deleted the feature/jaino/#128 branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐Ÿ”จํ”ฝ์Šค๐Ÿ”จ ๋ฒ„๊ทธ ๋ฐ ์ž ์žฌ์  ๋ฌธ์ œ ํ•ด๊ฒฐ ๐Ÿš€์ง„ํ˜ธ๐Ÿš€ ESTP ์ •์ง„ํ˜ธ 23์„ธ
Projects
None yet
2 participants