Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async http #7

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Async http #7

merged 3 commits into from
Jun 23, 2024

Conversation

pkelaita
Copy link
Owner

Fixed

  • In 0.0.21, async calls were blocking due to the use of requests. 0.0.22 replaces requests with httpx to allow for fully asynchoronous behavior.

Changed

  • AsyncLLMClient should now be instantiated with a context manager (async with AsyncLLMClient() as client:) to ensure proper cleanup of the httpx client.
  • AsyncLLMClient call_async and call_custom_async are now call and call_custom respectively, with asynchronous behavior.

Removed

  • call_concurrent and call_custom_concurrent have been removed due to unnecessary complexity and lack of use.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 99.59350% with 1 line in your changes missing coverage. Please review.

Files Coverage Δ
l2m2/__init__.py 100.00% <100.00%> (ø)
l2m2/_internal/http.py 100.00% <100.00%> (ø)
l2m2/client/async_llm_client.py 100.00% <100.00%> (ø)
l2m2/client/llm_client.py 100.00% <100.00%> (+0.49%) ⬆️
l2m2/client/base_llm_client.py 99.52% <99.52%> (ø)

@pkelaita pkelaita merged commit e2e6d8f into main Jun 23, 2024
10 of 12 checks passed
@pkelaita pkelaita deleted the async-http branch June 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant