Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A new feature (Contributers added in readme) #43

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Ram-tyagi
Copy link
Contributor

Type of change

  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@github-actions
Copy link

Thank you for following the naming conventions! 🙏

@Ram-tyagi
Copy link
Contributor Author

Screenshot 2023-10-11 220009

@piyushgarg-dev piyushgarg-dev added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 12, 2023
@piyushgarg-dev piyushgarg-dev merged commit 6232947 into piyushgarg-dev:main Oct 12, 2023
3 checks passed
Ram-tyagi added a commit to Ram-tyagi/review-app-api that referenced this pull request Oct 12, 2023
Merge pull request piyushgarg-dev#43 from Ram-tyagi/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants