This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
fix: uvs array might change if the region is updated and the uvs are more #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cacheData
structure might hold an olduvs
array when a region is updated.The PR just always reassigns the current
uvs
to the cache.The alternative would have been to check if the uvs length differs like this:
But the result would have been almost the same with an additional if check. In general
uvs
array changes very rarely, so in most of the case the if body would not have been executed.I don't see any performance improvement in keeping that if, so I just removed it and kept only the assignment.
This fixes a bug reported by a user on discord: https://discord.com/channels/734147990985375826/968068622327111681/1270951771564675134