Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9433: use PaginatedTable for Mod Version History #9527

Merged
merged 17 commits into from
Nov 15, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Nov 15, 2024

What does this PR do?

Discussion

Demo

image image

Future Work

For more information on our expectations for the PR process, see the
code review principles doc

@twschiller twschiller added the do not merge Merging of this PR is blocked by another one label Nov 15, 2024
@twschiller twschiller self-assigned this Nov 15, 2024
@twschiller twschiller added the user experience Improve the user experience (UX) label Nov 15, 2024
@twschiller twschiller mentioned this pull request Nov 15, 2024
5 tasks
@twschiller twschiller added the enhancement New feature or request label Nov 15, 2024
@twschiller twschiller changed the base branch from main to feature/9433-commit-modal November 15, 2024 13:07
@twschiller twschiller added this to the 2.2.1 milestone Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Playwright test results

passed  151 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 9 seconds
commit  ce90461
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/extensionConsole/modsPage.spec.ts › can open mod in the workshop
msedge › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Base automatically changed from feature/9433-commit-modal to main November 15, 2024 15:57
@grahamlangford
Copy link
Collaborator

grahamlangford commented Nov 15, 2024

We might need to consider overriding the sortType. Sorting by Updated By doesn't appear to work as expected

image

@twschiller twschiller removed the do not merge Merging of this PR is blocked by another one label Nov 15, 2024
@twschiller twschiller marked this pull request as draft November 15, 2024 16:32
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.81%. Comparing base (8318d74) to head (ce90461).
Report is 516 commits behind head on main.

Files with missing lines Patch % Lines
...ditor/tabs/modVersionHistory/ModVersionHistory.tsx 80.76% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9527      +/-   ##
==========================================
+ Coverage   74.24%   75.81%   +1.56%     
==========================================
  Files        1332     1429      +97     
  Lines       40817    43155    +2338     
  Branches     7634     7937     +303     
==========================================
+ Hits        30306    32718    +2412     
+ Misses      10511    10437      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 72fa4c2 into main Nov 15, 2024
25 checks passed
@twschiller twschiller deleted the feature/9433-version-paginated-table branch November 15, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request page editor user experience Improve the user experience (UX)
Development

Successfully merging this pull request may close these issues.

Mod Commit Messages
2 participants