Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9430: initialize nx configuration, and use nx task runner #9508

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Nov 12, 2024

What does this PR do?

  • Part of Slice 2: Add nx initial config and commands #9430
  • Adds initial nx.json configuration, dependency and swaps out the root scripts to use the nx task runner
  • Refactors projects to standardize on lint as the main script for linting the entire project fully
  • Tested by running nx tasks locally and confirming they run and cache successfully
    • nx graph outputs this simple diagram! Screenshot 2024-11-12 at 3 01 40 PM

Future Work

  • Install nx plugins for eslint and jest
  • Install nx plugin for js, and switch to using project references along with output js for each library

Checklist

  • This PR introduces a new library: double check it's MIT/Apache2/permissively licensed
    • MIT licensed

For more information on our expectations for the PR process, see the
code review principles doc

@fungairino fungairino marked this pull request as ready for review November 12, 2024 20:44
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (8318d74) to head (67a497e).
Report is 494 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9508      +/-   ##
==========================================
+ Coverage   74.24%   75.79%   +1.55%     
==========================================
  Files        1332     1421      +89     
  Lines       40817    42907    +2090     
  Branches     7634     7899     +265     
==========================================
+ Hits        30306    32523    +2217     
+ Misses      10511    10384     -127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitignore Outdated Show resolved Hide resolved
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

github-actions bot commented Nov 12, 2024

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 33 seconds
commit  67a497e
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/regressions/formFlicker.spec.ts › forms flickering due to components unexpectedly unmounting/remounting › #8320: Search field loses focus while typing on snippet mod

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

⚠️ Large diff for package-lock.json

There are 2835 line changes in package-lock.json. This should not happen unless you're updating a lot of dependencies at once. Regenerating the lockfile should not be necessary.

If you're seeing Vercel deployment failures, this is likely the cause.

Run these commands to reset these changes:

git checkout origin/main -- package-lock.json
npm install

You might want to click on "Update branch" first so that the results are accurate.

@fungairino fungairino enabled auto-merge (squash) November 12, 2024 21:05
@twschiller twschiller changed the title initialize nx configuration, and use nx task runner #9430: initialize nx configuration, and use nx task runner Nov 12, 2024
@fungairino fungairino merged commit 2196577 into main Nov 12, 2024
21 of 22 checks passed
@fungairino fungairino deleted the initialize-nx-config branch November 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants