Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8404: fix variable path regex to not switch to text entry mode during optional chaining #8635

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 16, 2024

What does this PR do?

Future Work

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer: @fungairino

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.65%. Comparing base (18c5348) to head (6672d13).
Report is 32 commits behind head on main.

Current head 6672d13 differs from pull request most recent head 3359226

Please upload reports for the commit 3359226 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8635      +/-   ##
==========================================
+ Coverage   73.63%   73.65%   +0.01%     
==========================================
  Files        1344     1344              
  Lines       41544    41577      +33     
  Branches     7767     7780      +13     
==========================================
+ Hits        30592    30624      +32     
- Misses      10952    10953       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 16, 2024

Playwright test results

passed  74 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  77 tests across 26 suites
duration  11 minutes, 22 seconds
commit  3359226

Flaky tests

edgeSetup › auth.setup.ts › authenticate

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@twschiller twschiller changed the title #8404: fix variable path regex to support optional chaining #8404: fix variable path regex to not switch to text entry mode during optional chaining Jun 16, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) June 17, 2024 16:02
@twschiller twschiller merged commit c32e86f into main Jun 17, 2024
19 checks passed
@twschiller twschiller deleted the feature/8404-variable-text-toggle branch June 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working page editor
3 participants