-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8382: brick to export data url as file #8383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8383 +/- ##
=======================================
Coverage 73.46% 73.47%
=======================================
Files 1333 1334 +1
Lines 41238 41251 +13
Branches 7678 7679 +1
=======================================
+ Hits 30297 30308 +11
- Misses 10941 10943 +2 ☔ View full report in Codecov by Sentry. |
Playwright test results - MV2Details Open report ↗︎ Skipped testschrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration |
Playwright test results - MV3Details Open report ↗︎ |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
@@ -0,0 +1,40 @@ | |||
/* | |||
* Copyright (C) 2024 PixieBrix, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30 strict null check errors due to messenger
super( | ||
"@pixiebrix/export/file", | ||
"[Experimental] Export as File", | ||
"Export/download a data URL as a file", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd probably just name this "Save to file" and (optionally?) use this new API https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker
What does this PR do?
Demo
Checklist