Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mv2 permissions #8379

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix mv2 permissions #8379

merged 2 commits into from
May 1, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

  • Removes the invalid offscreen permission from mv2 manifests
  • Ensures the offscreen permission is still added to mv3 manifests

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer @mnholtz

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller added this to the 1.8.14 milestone Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.49%. Comparing base (06960f0) to head (afd972a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8379      +/-   ##
==========================================
+ Coverage   73.46%   73.49%   +0.02%     
==========================================
  Files        1333     1333              
  Lines       41238    41238              
  Branches     7678     7678              
==========================================
+ Hits        30297    30306       +9     
+ Misses      10941    10932       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results - MV2

passed  34 passed
skipped  8 skipped

Details

report  Open report ↗︎
stats  42 tests across 16 suites
duration  7 minutes, 43 seconds
commit  afd972a

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Copy link

Playwright test results - MV3

passed  42 passed

Details

report  Open report ↗︎
stats  42 tests across 16 suites
duration  11 minutes, 7 seconds
commit  afd972a

@mnholtz
Copy link
Collaborator

mnholtz commented Apr 30, 2024

Thanks for catching this @grahamlangford

@twschiller twschiller merged commit afb4f9f into main May 1, 2024
36 checks passed
@twschiller twschiller deleted the fix-mv2-permissions branch May 1, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure
Development

Successfully merging this pull request may close these issues.

3 participants