-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mv2 permissions #8379
Fix mv2 permissions #8379
Conversation
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8379 +/- ##
==========================================
+ Coverage 73.46% 73.49% +0.02%
==========================================
Files 1333 1333
Lines 41238 41238
Branches 7678 7678
==========================================
+ Hits 30297 30306 +9
+ Misses 10941 10932 -9 ☔ View full report in Codecov by Sentry. |
Playwright test results - MV2Details Open report ↗︎ Skipped testschrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration |
Playwright test results - MV3Details Open report ↗︎ |
Thanks for catching this @grahamlangford |
What does this PR do?
offscreen
permission from mv2 manifestsoffscreen
permission is still added to mv3 manifestsChecklist