Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8326 - Fix page editor warning indicator when using a brick with the implicit PixieBrix api integration #8339

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

BLoe
Copy link
Contributor

@BLoe BLoe commented Apr 24, 2024

What does this PR do?

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer - @grahamlangford

@BLoe BLoe self-assigned this Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (9d6b94b) to head (b11d93a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8339   +/-   ##
=======================================
  Coverage   73.49%   73.50%           
=======================================
  Files        1330     1330           
  Lines       41111    41108    -3     
  Branches     7637     7637           
=======================================
  Hits        30216    30216           
+ Misses      10895    10892    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@BLoe BLoe merged commit dba6fdd into main Apr 24, 2024
22 checks passed
@BLoe BLoe deleted the bug/8326-unknown-variable-warning-for-pb-integration branch April 24, 2024 21:29
@twschiller twschiller added this to the 1.8.13 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Variable warning for bricks using PixieBrix API
3 participants