test: using stable/oldstable aliases #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If stable is provided, action will get the latest stable version from the go-versions repository manifest. If oldstable is provided, when current release is 1.19.x, action will resolve version as 1.18.x, where x is the latest patch release. We also want to maintain 1.20 version, so we test it. [#186180915](https://www.pivotaltracker.com/story/show/186180915)
blgm
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Great. This keeps the repo up to date with new Go versions automatically.
At the moment oldstable == 1.20 so we have a duplication, but that's deliberate as oldstable will change in time. We keep 1.20 because that's the version of the Go directive in the go.mod and it's sensible to check that this version always works. We may update it in the future, but want that to be considered rather than automatic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If stable is provided, action will get the latest stable version from the go-versions repository manifest.
If oldstable is provided, when current release is 1.19.x, action will resolve version as 1.18.x, where x is the latest patch release.
We also want to maintain 1.20 version, so we test it.
#186180915