Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#208 Updating readme to add badge #209

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

#208 Updating readme to add badge #209

wants to merge 3 commits into from

Conversation

Conor0Callaghan
Copy link

Add badge to README as per #208 part 1

@Conor0Callaghan
pittcsc#208 Updating readme to add badge
e307035 
Add badge to README as per pittcsc#208 part 1
rohit-ganguly
rohit-ganguly reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@rohit-ganguly rohit-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the shield, that's awesome. I think it would be useful to add a short section around installation via pip/pipenv too towards the start of the doc!

tianyizheng02
tianyizheng02 requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For convenience, is it possible to have the badge be a clickable link to PittAPI's PyPI page?

@Conor0Callaghan
Merge branch 'pittcsc:dev' into dev
807d4b2
@Conor0Callaghan
Update README.md
de6bca8 
Updating Readme with first attempt at additional install commands as per comments in pittcsc#208
@Conor0Callaghan
Copy link
Author

Thanks for adding the shield, that's awesome. I think it would be useful to add a short section around installation via pip/pipenv too towards the start of the doc!

hopefully that's a good start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-ganguly rohit-ganguly rohit-ganguly left review comments

@tianyizheng02 tianyizheng02 Awaiting requested review from tianyizheng02

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Conor0Callaghan @rohit-ganguly @tianyizheng02