Refactor sports.py
to use NamedTuple
, fix mypy
errors
#201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #45 by fixing existing type hint errors prior to introducing
mypy
to the repo.Run
mypy
with--strict
flag to fix type hints insports.py
Refactor
sports.py
to store API output usingNamedTuple
s rather than plain Pythondict
s. This makes the output more user-friendly, less error-prone, and easier to type-hint.Before:
After:
Like in #193, the remaining
missing-imports
error will need to be ignored with--ignore-missing-imports
becausegevent
simply doesn't provide any type hints formypy
.