Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store records with null coordinates in separate array #87

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

mbilker
Copy link
Collaborator

@mbilker mbilker commented Jan 28, 2017

This PR is a continuation on #61 to store coordinates in a separate array so something can be done with them later.

Copy link
Contributor

@vonbearshark vonbearshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought this might not be a good way to go about this. There's a lot of benefits to having only one marker array (we only have to filter through one), but that would get complex with all the conditionals checking if it was a pin or a non-placed marker. So this is probably the best solution. FWIW, it's not just null location pins, it's also pins that just don't fall within Oakland.

@vonbearshark vonbearshark merged commit d993cab into pittcsc:master Jan 28, 2017
@mbilker mbilker deleted the null-record-stash branch January 28, 2017 01:41
@mbilker
Copy link
Collaborator Author

mbilker commented Jan 28, 2017

Alright, thank you. I know that some of the police ones are outside of Oakland because the original case was reported in Oakland, say for stolen vehicles.

@vonbearshark
Copy link
Contributor

vonbearshark commented Jan 28, 2017

Right, we've been talking about this in #13 and #61 , and the consensus is that we want to limit the map view to only Oakland (not even allowed to scroll to outside it), but we also want to show the pins that originate outside Oakland. So we want to identify if a pin would be placed outside the Oakland bounding box we have, then place it with the pins that don't have any location given.

@mbilker mbilker restored the null-record-stash branch January 28, 2017 01:55
@mbilker
Copy link
Collaborator Author

mbilker commented Jan 28, 2017

How about extraRecords for the variable name?

@vonbearshark
Copy link
Contributor

nonPlacedRecords?

@mbilker
Copy link
Collaborator Author

mbilker commented Jan 28, 2017

That sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants