Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain map zoom and pan to Pittsburgh, start centered on Cathedral #59

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Conversation

brlodi
Copy link
Collaborator

@brlodi brlodi commented Jan 25, 2017

As discussed in issue #13. This doesn't filter or normalize any data, just constrains the map view to a reasonable area.
The Ghana (0, 0) pin is still lurking out there, somewhere. 😛

Copy link
Member

@RitwikGupta RitwikGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max bounds could be a little smaller, but this is still great. We can discuss max bounds separately if it's a real issue.

@RitwikGupta RitwikGupta merged commit 91d9a68 into pittcsc:master Jan 25, 2017
@brlodi
Copy link
Collaborator Author

brlodi commented Jan 25, 2017

If the bounds are any smaller, zooming out from the default pan location starts getting jostled around by the bounds before reaching minZoom, and I found that feels really bad.

@vonbearshark
Copy link
Contributor

What if we disallow zooming out past the default? I agree that we should narrow this a little more if we can, and collect the pins that fall outside Oakland to a default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants