Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big overhaul. MVP for TPN integration #134

Merged
merged 1 commit into from
May 7, 2017
Merged

Big overhaul. MVP for TPN integration #134

merged 1 commit into from
May 7, 2017

Conversation

vonbearshark
Copy link
Contributor

Addresses #26, #46, and a little of #133. If it works, we should let the Pitt News know we're good to go

@vonbearshark
Copy link
Contributor Author

vonbearshark commented May 7, 2017 •
edited
Loading

I can't merge since I took myself out of the organization. Maybe @johnlinahan might be interested?

You'll want to look into #133 more. See what the club wants to do about that. Right now we need to include 4 files: data.js,map.js,ui.js, and main.css. TPN (and whomever) can download them for now, but it would be better to host them on a CDN. But I'll leave that to the officers to figure out w/ the club. I have a line the README with what's needed, you just need to change the relative paths to the CDN paths.

You might also want to get the feedback for set up for #132, so we can add that in before TPN downloads it (if that's the way you decide to do it). I mean either way it would be good to get. You can put a link to it in the footer part of ui.js easily so it's included.

@johnlinahan johnlinahan merged commit 7d4942b into pittcsc:master May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonbearshark @johnlinahan