MultiList: validate both min and max on keyenter #173
Conversation
sveinn
changed the title
There was a problem hiding this comment.
Thank you for submitting this PR.
As things stand I'm unable to accept it. At a minimum, there needs to be a test case that proves the issue has been fixed. Also, I'd like you to revert any formatting changes to the code that isn't affected directly by the issue. My preference is for PR to be focused on what is being fixed/added. I'd also appreciate an entry in the changelog.
sveinn
force-pushed
the
issue-172
branch
2 times, most recently
from
da54e43
to
576ff32
Compare
My pleasure. I've addressed your requests, please let me know if I missed anything. Thanks! |
There was a problem hiding this comment.
Thank you for working on the changes. It seems you have missed out on a variable that affects some tests. I left few extra comments to keep the tests focused. Whilst reviewing I noticed that it would be good to consider the situation when a user provides min greater than max. Should we check for this and raise an appropriate and meaningful error?
sveinn
force-pushed
the
issue-172
branch
2 times, most recently
from
5e5fa29
to
62c6f40
Compare
Woops, sorry about that.
Good idea. Made a stab at this, let me know what you think. |
Sure thing. Just addressed your comments. Lemme know if there are any more, or if I missed something. Thanks! |
There was a problem hiding this comment.
Thank you for such a quick turnaround. I left a comment on the changelog description. One thing to make you aware of is that I'm planning to merge another PR before yours as it was long in waiting and it is a significant change. There shouldn't be any conflicts with your work but you'll need to rebase.
CHANGELOG.md
Outdated
| * Fix MultiList#keyenter validation - min option also validated now when both min and max are specified. | ||
| * Fix MultiList#keyenter validation - ensure min is not greater than max |
There was a problem hiding this comment.
I'd consider rewording without pointing to any particular method. The validation also ensures that you cannot select more than the allowed number of choices before confirming your selection. The second point arguably could be thought of as change rather than a fix and recorded as such?
There was a problem hiding this comment.
I'd consider rewording without pointing to any particular method.
Makes sense. How about we change it to multi_list since that's what the user interacts with?
The validation also ensures that you cannot select more than the allowed number of choices before confirming your selection.
Yes. I didn't call this out in the changelog since this was already in working order prior to my fix. Would you like me to mention it though?
The second point arguably could be thought of as change rather than a fix and recorded as such?
Good point.
What are your thoughts on this:
### Fixed
* Fix multi_select validation - min option also validated now when both min and max are specified
### Changed
* Change multi_select validation to ensure min is not greater than max
There was a problem hiding this comment.
Made a change and re-requested a review. (reads multi select instead of multi_select since you had suggested to not refer to a particular method)
|
👋🏾 Hi there, is there any additional help needed on this PR? I was just about to open a new one, but I'd love to help get this one merged instead 😃 |
Describe the change
Fixes issue 172
Requirements
masterbranch?