Fix setting the current progress for an indeterminate bar #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 23, 2023
alexcwatt
force-pushed
the
set-current-indeterminate
branch
from
3b74608
to
9a60a52
Compare
houndci-bot
reviewed
Aug 23, 2023
alexcwatt
force-pushed
the
set-current-indeterminate
branch
from
9a60a52
to
d0dca1d
Compare
piotrmurach
reviewed
Aug 26, 2023
alexcwatt
force-pushed
the
set-current-indeterminate
branch
from
d0dca1d
to
d02410f
Compare
houndci-bot
reviewed
Aug 27, 2023
alexcwatt
force-pushed
the
set-current-indeterminate
branch
from
d02410f
to
c6f61b2
Compare
|
@piotrmurach The errors now focus on "numeric" instead of a particular class. Let me know what you think! |
piotrmurach
reviewed
Sep 11, 2023
alexcwatt
force-pushed
the
set-current-indeterminate
branch
from
c6f61b2
to
110530b
Compare
|
@piotrmurach I've made that small change for consistency |
|
@piotrmurach let me know if you want me to do anything else to make this mergeable |
|
@alexcwatt This is on my list, I promise I'm not ignoring you. Please bear with me. |
piotrmurach
force-pushed
the
set-current-indeterminate
branch
from
110530b
to
75849ff
Compare
piotrmurach
changed the title
piotrmurach
pushed a commit
that referenced
this pull request
Nov 10, 2024
|
@alexcwatt Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
I noticed that
#current=failed for indeterminate progress bars. The primary test I added would error like this:I added a new
ArgumentErrorguard to also preserve the existing, desirable, behavior of not supporting#current = nil, and a test to cover this. Note thatcurrent = nilwas already raisingArgumentErrorin both the determinate and indeterminate cases (comparison of Integer with nil failed,comparison of NilClass with 0 failed, etc.); now the error message is one that we set.Why are we doing this?
As far as I can tell, there's no reason that
current =shouldn't work for indeterminate progress bars. It seems that indeterminate progress bars are meant to have acurrentvalue, and can have it by calling.advance, so adding support seems consistent with the rest of the library.Benefits
It's quite nice to be able to set current progress for indeterminate progress bars!
Drawbacks
I don't have any to highlight.
Requirements
masterbranch?